Migrate stringentity #70
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/apache/httpclient5/MigrateStringEntity.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/apache/httpclient5/MigrateStringEntity.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/apache/httpclient5/MigrateStringEntityTest.java
Show resolved
Hide resolved
| @EqualsAndHashCode(callSuper = false) | ||
| public class MigrateStringEntity extends Recipe { | ||
|
|
||
| private static final String METHOD_PATTERN = "org.apache.http.entity.StringEntity setContentEncoding(..)"; |
There was a problem hiding this comment.
Should be "org.apache.http.entity.AbstractHttpEntity setContentEncoding(..)" instead, as the method you're trying to target belongs the the parent class rather than to StringEntity
src/test/java/org/openrewrite/apache/httpclient5/MigrateStringEntityTest.java
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| if ("ANY".equals(f.getSimpleName()) && TypeUtils.isOfClassType(f.getTarget().getType(), "org.apache.hc.client5.http.auth.AuthScope")) { | ||
| maybeAddImport("org.apache.hc.client5.http.auth.AuthScope"); | ||
| return JavaTemplate.builder("new AuthScope(null, -1)") | ||
| .imports("org.apache.hc.client5.http.auth.AuthScope") | ||
| .javaParser(JavaParser.fromJavaVersion().classpathFromResources(ctx, "httpcore5")) | ||
| .build() | ||
| .apply(updateCursor(f), f.getCoordinates().replace()); | ||
| } |
There was a problem hiding this comment.
This is implementation copied from the MigrateAuthScope recipe here, correct? I think perhaps rather than using visitFieldAccess(..) you might want to take a look at visitVariableDeclaration(..) or visitNewClass(..) for getting to the existing assignment of a new StringEntity(..) to a variable and visitMethodInvocation(..) for getting to the calling of setEncoding(..).
You might also find the RemoveMethodInvocationsVisitor useful for getting rid of the setEncoding(..)
|
This PR is stale because it has been open for 90 days with no activity. Remove |
What's changed?
This PR adds a new
org.openrewrite.apache.httpclient5.MigrateStringEntityrecipe that migratesStringEntity.setContentEncoding(..).What's your motivation?
StringEntity.setContentEncoding()to constructor argument #54Anything in particular you'd like reviewers to focus on?
Draft, still at an early stage. I am getting an
AssertionErrorwhen running the test:Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist